Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add consensus basic notes #14

Merged
merged 10 commits into from
Aug 8, 2023
Merged

docs: add consensus basic notes #14

merged 10 commits into from
Aug 8, 2023

Conversation

Arkenan
Copy link
Collaborator

@Arkenan Arkenan commented Aug 2, 2023

Description

This PR adds some notes for the basic theory of fork-choice in ethereum

Closes #13

@mpaulucci mpaulucci changed the title docs: Add consensus basic notes docs: add consensus basic notes Aug 2, 2023
@Arkenan Arkenan marked this pull request as ready for review August 4, 2023 17:14
@Arkenan Arkenan requested a review from a team as a code owner August 4, 2023 17:14
Copy link
Collaborator

@MegaRedHand MegaRedHand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments.
Also, I found the main consensus doc confusing, because of the mention of the EVM and EL transactions. As I understand, in the consensus layer the beacon operations would serve as txs, while the state transition function would be the state machine. I think at some point the text should mention this.

docs/fork_choice.md Outdated Show resolved Hide resolved
docs/fork_choice.md Outdated Show resolved Hide resolved
docs/fork_choice.md Outdated Show resolved Hide resolved
docs/fork_choice.md Outdated Show resolved Hide resolved
docs/fork_choice.md Outdated Show resolved Hide resolved
docs/fork_choice.md Outdated Show resolved Hide resolved
docs/consensus.md Outdated Show resolved Hide resolved
docs/consensus.md Outdated Show resolved Hide resolved
docs/fork_choice.md Outdated Show resolved Hide resolved
docs/fork_choice.md Outdated Show resolved Hide resolved
docs/fork_choice.md Outdated Show resolved Hide resolved
Arkenan and others added 5 commits August 8, 2023 15:52
Co-authored-by: Tomás <47506558+MegaRedHand@users.noreply.github.com>
Co-authored-by: Tomás <47506558+MegaRedHand@users.noreply.github.com>
Co-authored-by: Tomás <47506558+MegaRedHand@users.noreply.github.com>
Co-authored-by: Tomás <47506558+MegaRedHand@users.noreply.github.com>
Co-authored-by: Tomás <47506558+MegaRedHand@users.noreply.github.com>
@Arkenan Arkenan merged commit 5d26272 into main Aug 8, 2023
4 checks passed
@Arkenan Arkenan deleted the consensus-notes branch August 8, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add theory basics for fork-choice
2 participants