-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate new FFT iterative algorithms and tidy-up the FFT API #167
Conversation
This reverts commit 15a4d70.
Codecov Report
@@ Coverage Diff @@
## main #167 +/- ##
==========================================
+ Coverage 96.16% 96.40% +0.24%
==========================================
Files 52 51 -1
Lines 6334 6369 +35
==========================================
+ Hits 6091 6140 +49
+ Misses 243 229 -14
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor details but everything looks good
Co-authored-by: Nacho Avecilla <iavecilla@fi.uba.ar>
Co-authored-by: Nacho Avecilla <iavecilla@fi.uba.ar>
Co-authored-by: Nacho Avecilla <iavecilla@fi.uba.ar>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Integrate new FFT algorithms and tidy-up the FFT API
Description
This is a follow up of #127. The changes remove the previous recursive FFT algorithm and integrates the new, faster ones. Also adds new methods for twiddle/roots of unity generation and tidies-up the API in general.
This is part of our efforts for #116.
Type of change
Please delete options that are not relevant.
Checklist