Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate new FFT iterative algorithms and tidy-up the FFT API #167

Merged
merged 21 commits into from
Mar 13, 2023
Merged

Conversation

xqft
Copy link
Member

@xqft xqft commented Mar 9, 2023

Integrate new FFT algorithms and tidy-up the FFT API

Description

This is a follow up of #127. The changes remove the previous recursive FFT algorithm and integrates the new, faster ones. Also adds new methods for twiddle/roots of unity generation and tidies-up the API in general.

This is part of our efforts for #116.

Type of change

Please delete options that are not relevant.

  • New feature
  • Optimization

Checklist

  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.

@xqft xqft requested review from a team, schouhy and ajgara as code owners March 9, 2023 17:39
@codecov-commenter
Copy link

Codecov Report

Merging #167 (e8e006d) into main (95fe19f) will increase coverage by 0.24%.
The diff coverage is 98.98%.

@@            Coverage Diff             @@
##             main     #167      +/-   ##
==========================================
+ Coverage   96.16%   96.40%   +0.24%     
==========================================
  Files          52       51       -1     
  Lines        6334     6369      +35     
==========================================
+ Hits         6091     6140      +49     
+ Misses        243      229      -14     
Impacted Files Coverage Δ
math/src/fft/fft_iterative.rs 100.00% <ø> (ø)
math/src/field/traits.rs 93.15% <95.65%> (+4.91%) ⬆️
math/src/fft/abstractions.rs 100.00% <100.00%> (ø)
math/src/fft/bit_reversing.rs 100.00% <100.00%> (ø)
math/src/polynomial.rs 98.42% <100.00%> (+0.38%) ⬆️
math/src/field/test_fields/u64_test_field.rs 81.57% <0.00%> (+7.89%) ⬆️
math/src/fft/helpers.rs 100.00% <0.00%> (+37.50%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xqft xqft mentioned this pull request Mar 9, 2023
7 tasks
Copy link
Collaborator

@IAvecilla IAvecilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor details but everything looks good

math/benches/benchmarks/fft.rs Outdated Show resolved Hide resolved
math/benches/benchmarks/fft.rs Outdated Show resolved Hide resolved
math/src/fft/abstractions.rs Outdated Show resolved Hide resolved
math/src/field/traits.rs Outdated Show resolved Hide resolved
math/src/polynomial.rs Outdated Show resolved Hide resolved
math/src/polynomial.rs Outdated Show resolved Hide resolved
math/src/polynomial.rs Outdated Show resolved Hide resolved
math/src/polynomial.rs Outdated Show resolved Hide resolved
math/src/field/traits.rs Outdated Show resolved Hide resolved
math/src/field/traits.rs Outdated Show resolved Hide resolved
xqft and others added 4 commits March 10, 2023 14:30
Co-authored-by: Nacho Avecilla <iavecilla@fi.uba.ar>
Co-authored-by: Nacho Avecilla <iavecilla@fi.uba.ar>
Co-authored-by: Nacho Avecilla <iavecilla@fi.uba.ar>
@xqft xqft enabled auto-merge March 10, 2023 18:10
Copy link
Collaborator

@ilitteri ilitteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xqft xqft added this pull request to the merge queue Mar 13, 2023
Merged via the queue into main with commit bf3c361 Mar 13, 2023
@xqft xqft deleted the fft-api branch March 13, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants