feat(proptest): Implement proptest::Arbitrary for UnsignedInteger
#526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Open to any feedback! Always looking to improve. |
Codecov Report
@@ Coverage Diff @@
## main #526 +/- ##
==========================================
- Coverage 94.49% 94.16% -0.33%
==========================================
Files 62 62
Lines 8987 8857 -130
==========================================
- Hits 8492 8340 -152
- Misses 495 517 +22
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Oppen
reviewed
Aug 16, 2023
math/Cargo.toml
Outdated
| @@ -11,6 +11,7 @@ license.workspace = true | |||
| thiserror = { version = "1.0", optional = true } | |||
| serde = { version = "1.0", features = ["derive"], optional = true } | |||
| serde_json = { version = "1.0", optional = true } | |||
| proptest = "1.1.0" | |||
There was a problem hiding this comment.
Please, make this dependency optional and use a feature flag. We don't want to force the dependency for users who aren't interested in testing with arbitrary numbers.
Oppen
reviewed
Aug 22, 2023
MauroToscano
approved these changes
Aug 31, 2023
schouhy
approved these changes
Aug 31, 2023
diegokingston
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #414
Adds an implementation of
proptest::ArbitraryforUnsignedInteger. Refactors proptests to useany::<UnsignedInteger>()