Feat/bn 254 #646
Merged
Feat/bn 254 #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #646 +/- ##
==========================================
- Coverage 94.59% 94.34% -0.25%
==========================================
Files 144 148 +4
Lines 33838 34141 +303
==========================================
+ Hits 32008 32211 +203
- Misses 1830 1930 +100 ☔ View full report in Codecov by Sentry. |
5 tasks
* initial commit * change serde_cbor for serde_bare * bincode de/ser * remove comparison * fmt * restore flag * fix failing test * add std feature flag * conditional use * rmv conditional use * replace std for core * add cond import * rmv unused import * rplc todo w unimplemented * Update provers/cairo/src/main.rs --------- Co-authored-by: Mauro Toscano <12560266+MauroToscano@users.noreply.github.com>
* initial commit * change serde_cbor for serde_bare * bincode de/ser * remove comparison * fmt * restore flag * fix failing test * add std feature flag * conditional use * rmv conditional use * replace std for core * add cond import * rmv unused import * rplc todo w unimplemented * Update provers/cairo/src/main.rs --------- Co-authored-by: Mauro Toscano <12560266+MauroToscano@users.noreply.github.com>
* update wasm with new verifier api * fmt * Re add wasm compile and test * Add wasm commands to makefile * Add wasm commands to makefile * Fix wasm commands * Fix wasm * Fix wasm CI * Fmt * Fmt + fmt ci wasm * Compatibility with main * Fix * Fmt * Remove unnecesary clone * Fix linters * Raise security * Re add dep * Wasm --------- Co-authored-by: Mauro Toscano <12560266+MauroToscano@users.noreply.github.com> Co-authored-by: MauroFab <maurotoscano2@gmail.com>
PatStiles
force-pushed
the
feat/bn_256
branch
from
d13d7e0
to
5335e45
Compare
math/src/elliptic_curve/short_weierstrass/curves/bn_254/twist.rs
Outdated
Show resolved
Hide resolved
Comment on lines
63
to
77
| impl ShortWeierstrassProjectivePoint<BN254TwistCurve> { | ||
| /// This function is related to the map ψ: E_twist(𝔽p²) -> E(𝔽p¹²). | ||
| /// Given an affine point G in E_twist(𝔽p²) returns x, y such that | ||
| /// ψ(G) = (x', y', 1) with x' = x * x'' and y' = y * y'' | ||
| /// for some x'', y'' in 𝔽p². | ||
| /// This is meant only to be used in the miller loop of the | ||
| /// ate pairing before the final exponentiation. | ||
| /// This is because elements in 𝔽p² raised to that | ||
| /// power are 1 and so the final result of the ate pairing | ||
| /// doens't depend on having this function output the exact | ||
| /// values of x' and y'. And it is enough to work with x and y. | ||
| pub fn to_fp12_unnormalized(&self) -> [FieldElement<Degree12ExtensionField>; 2] { | ||
| todo!() | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| impl ShortWeierstrassProjectivePoint<BN254TwistCurve> { | |
| /// This function is related to the map ψ: E_twist(𝔽p²) -> E(𝔽p¹²). | |
| /// Given an affine point G in E_twist(𝔽p²) returns x, y such that | |
| /// ψ(G) = (x', y', 1) with x' = x * x'' and y' = y * y'' | |
| /// for some x'', y'' in 𝔽p². | |
| /// This is meant only to be used in the miller loop of the | |
| /// ate pairing before the final exponentiation. | |
| /// This is because elements in 𝔽p² raised to that | |
| /// power are 1 and so the final result of the ate pairing | |
| /// doens't depend on having this function output the exact | |
| /// values of x' and y'. And it is enough to work with x and y. | |
| pub fn to_fp12_unnormalized(&self) -> [FieldElement<Degree12ExtensionField>; 2] { | |
| todo!() | |
| } | |
| } |
README.md
Outdated
Comment on lines
239
to
240
|
|
||
| testing |
There was a problem hiding this comment.
Suggested change
| testing |
PatStiles
force-pushed
the
feat/bn_256
branch
from
2a9c1d4
to
263c392
Compare
PatStiles
force-pushed
the
feat/bn_256
branch
from
e5b80bf
to
7440724
Compare
PatStiles
force-pushed
the
feat/bn_256
branch
from
796f9b4
to
0ecdb7b
Compare
PatStiles
force-pushed
the
feat/bn_256
branch
from
8af2bfc
to
fb49110
Compare
PatStiles
force-pushed
the
feat/bn_256
branch
from
b039326
to
c8339e9
Compare
diegokingston
previously approved these changes
Jan 30, 2024
math/src/elliptic_curve/short_weierstrass/curves/bn_254/twist.rs
Outdated
Show resolved
Hide resolved
diegokingston
approved these changes
Jan 30, 2024
MauroToscano
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add BN254
Description
Implementation of BN254 #548 to be finished with @protocolwhisper
Implements:
Type of change
Please delete options that are not relevant.
Checklist