Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vesta curve basic functionality #714

Merged
merged 8 commits into from
Jan 2, 2024

Conversation

mdvillagra
Copy link
Contributor

Add Vesta curve basic functionality

Description

This PR adds the Vesta curve with only basic functionality.

Type of change

  • New feature

Checklist

  • Unit tests added

@mdvillagra mdvillagra requested review from schouhy, ajgara and a team as code owners December 11, 2023 14:17
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7a84ab5) 96.22% compared to head (2d31a4e) 96.05%.
Report is 4 commits behind head on main.

Files Patch % Lines
...ptic_curve/short_weierstrass/curves/vesta/curve.rs 98.95% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #714      +/-   ##
==========================================
- Coverage   96.22%   96.05%   -0.18%     
==========================================
  Files         132      134       +2     
  Lines       29750    30090     +340     
==========================================
+ Hits        28627    28903     +276     
- Misses       1123     1187      +64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@entropidelic entropidelic added this pull request to the merge queue Jan 2, 2024
Merged via the queue into lambdaclass:main with commit 5b771ee Jan 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants