Stark: Prover and Verifier over field extensions v2 #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #717 +/- ##
==========================================
- Coverage 95.77% 95.75% -0.03%
==========================================
Files 135 135
Lines 30136 30293 +157
==========================================
+ Hits 28863 29007 +144
- Misses 1273 1286 +13 ☔ View full report in Codecov by Sentry. |
2 tasks
schouhy
force-pushed
the
stark-prover-over-field-extensions-v2
branch
from
4e0833d
to
ef3da23
Compare
Oppen
reviewed
Dec 18, 2023
diegokingston
approved these changes
Dec 19, 2023
MauroToscano
approved these changes
Dec 20, 2023
entropidelic
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prover and Verifier over field extensions v2
Description
This is an improvement over PR #716 that avoid casting the trace to the field extension. The immediate consequence is that the prover can no longer consider all trace polynomials and all trace LDE evaluations as a single object since they live in different fields. This PR refactors the prover's and verifier's code to handle those different types.
Evaluation of constraints to build the composition polynomial still considers all columns to live in the field extension. A followup PR will improve that to fully leverage the optimized ops between different fields. This is so divided in two different PRs for making the review process easier.