Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test/swap #193

Open
wants to merge 41 commits into
base: main
Choose a base branch
from
Open

Test/swap #193

wants to merge 41 commits into from

Conversation

rcatalan98
Copy link
Collaborator

@rcatalan98 rcatalan98 commented Dec 1, 2023 •
edited by uri-99
Loading

This PR solves issue #149
Swap tests were dividied into Pool Cases, and also Swap Cases. Then, each Swap Case is executed in each Pool Case.

This is why this Issue is divided into smaller issues, one issue per Pool Case.

This PR will be done and merged into main branch after all pool cases are done and working correctly.

uri-99 and others added 17 commits November 8, 2023 14:09
@uri-99
Feat: Pool0 fully tested
5c22293
@uri-99
Feat: pool 9 with same error as pool 8
6b3474d
Fix: obtain_swap_cases
026ce72
@uri-99
WIP: price to x96 format
f26362c
@dubzn
migrate round price (wip)
058a04b
@dubzn
add methods for precision
2cbc7d5
@dubzn
add presicion param for tests
d268048
@dubzn
adding amounts params for setup
81dc316
@dubzn
fix add amounts to approve req
704136f
@dubzn
Revert "add presicion param for tests"
2541397 
This reverts commit d268048.
Merge branch 'test/swap' into pool-9
48996aa
@uri-99
fix exec price dividing by 0 bug (#184)
a2d00a1 
Co-authored-by: Uriel Mihura <uriel.mihura@gmail.com>
Merge branch 'test/swap' into pool-9
a0550ae
wip swap_amt=0 test fix
18ed3dd
Merge branch 'pool-9' into test/swap
70ec219
Revert "Merge branch 'pool-9' into test/swap"
5f6441a 
This reverts commit 70ec219, reversing
changes made to a2d00a1.
@dpinones
Fix CI Test & Katana (#192)
68f57df
@rcatalan98 rcatalan98 marked this pull request as ready for review December 1, 2023 18:49
Uriel Mihura and others added 10 commits December 1, 2023 15:53
make fmt
a792eab
@uri-99 @dubzn
add swap() tests for Pool 0 (#158)
e51cd04 
Co-authored-by: Uriel Mihura <uriel.mihura@gmail.com>
Co-authored-by: dubzn <santiagodgalvan@gmail.com>
@dubzn @rcatalan98
Add swap() tests for Pool 2 (#179)
973836e 
Co-authored-by: Uriel Mihura <uriel.mihura@gmail.com>
Co-authored-by: rcatalan98 <robertitocatalan@gmail.com>
@uri-99 @dubzn
add swap() tests for Pool 5 (#160)
978415c 
Co-authored-by: Uriel Mihura <uriel.mihura@gmail.com>
Co-authored-by: dubzn <santiagodgalvan@gmail.com>
Fix pool2 error from merge
8a6728c
use Zeroable::zero() in panic cases
7a1ebbf
@dubzn
Merge branch 'main' into test/swap
73b0cd8
@uri-99
add swap() tests for Pool 9 (#197)
b47faaf 
Co-authored-by: Uriel Mihura <uriel.mihura@gmail.com>
@uri-99 @dubzn
add swap() tests for Pool 6 (#177)
e67656e 
Co-authored-by: Uriel Mihura <uriel.mihura@gmail.com>
Co-authored-by: Santiago Galván (Dub) <santiagodgalvan@gmail.com>
@uri-99
Add usage of swap(-x) in test (#194)
022d096 
Co-authored-by: Uriel Mihura <uriel.mihura@gmail.com>
uri-99 and others added 12 commits December 11, 2023 12:25
@uri-99
Add -Inf case (#196)
5723427 
Co-authored-by: Uriel Mihura <uriel.mihura@gmail.com>
@dubzn
Refactor swap tests (#200)
21e4245
@dubzn @uri-99
Add swap() tests for Pool 3 (#181)
9183529 
Co-authored-by: Uriel Mihura <uriel.mihura@gmail.com>
Co-authored-by: Uri <umihura@itba.edu.ar>
@dpinones @dubzn
Add swap() tests for Pool 14 (#182)
0a1ec61 
Co-authored-by: Santiago Galván (Dub) <santiagodgalvan@gmail.com>
@dubzn @dpinones
Add swap() tests for Pool 13 (#185)
2e403ce 
Co-authored-by: Uriel Mihura <uriel.mihura@gmail.com>
Co-authored-by: dpinones <pinonesdamian@gmail.com>
@uri-99 @dubzn @dpinones
add swap() tests for Pool 7 (#186)
360f8eb 
Co-authored-by: Uriel Mihura <uriel.mihura@gmail.com>
Co-authored-by: dubzn <santiagodgalvan@gmail.com>
Co-authored-by: dpinones <pinonesdamian@gmail.com>
@uri-99 @dpinones @dubzn
add swap() tests for Pool 8 (#187)
b4a7727 
Co-authored-by: Uriel Mihura <uriel.mihura@gmail.com>
Co-authored-by: dpinones <pinonesdamian@gmail.com>
Co-authored-by: dubzn <santiagodgalvan@gmail.com>
@uri-99 @dubzn @dpinones
add swap() tests for Pool 10 (#189)
e80624f 
Co-authored-by: Uriel Mihura <uriel.mihura@gmail.com>
Co-authored-by: Santiago Galván (Dub) <santiagodgalvan@gmail.com>
Co-authored-by: dpinones <pinonesdamian@gmail.com>
@uri-99 @dpinones
add swap() tests for Pool 12 (#191)
8257776 
Co-authored-by: dpinones <pinonesdamian@gmail.com>
Co-authored-by: Damián Piñones <30808181+dpinones@users.noreply.github.com>
Co-authored-by: Uriel Mihura <uriel.mihura@gmail.com>
@uri-99
Test/fix pool bug (#204)
6dc62de 
Co-authored-by: Uriel Mihura <uriel.mihura@gmail.com>
@uri-99 @dubzn @dpinones
Add swap() tests for Pool 4 (#159)
6bd7cd2 
Co-authored-by: Uriel Mihura <uriel.mihura@gmail.com>
Co-authored-by: dubzn <santiagodgalvan@gmail.com>
Co-authored-by: dpinones <pinonesdamian@gmail.com>
@uri-99 @dubzn @dpinones
add swap() tests for Pool 11 (#190)
3b82940 
Co-authored-by: Uriel Mihura <uriel.mihura@gmail.com>
Co-authored-by: dubzn <santiagodgalvan@gmail.com>
Co-authored-by: dpinones <pinonesdamian@gmail.com>
uri-99
uri-99 previously approved these changes Jan 2, 2024
View reviewed changes
@uri-99
Revert "trigger CI"
3689197 
This reverts commit 2c2c06e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uri-99 uri-99 uri-99 left review comments

@dpinones dpinones Awaiting requested review from dpinones

@dubzn dubzn Awaiting requested review from dubzn

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rcatalan98 @uri-99 @dubzn @dpinones