Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor - Add NaN to expected values (Pool 8) #202

Open
wants to merge 23 commits into
base: test/swap
Choose a base branch
from

Conversation

dpinones
Copy link
Contributor

Just like Uniswap V3 in the case of Pool 8, when the deltas resulting from a transaction are 0, and then you want to calculate the execution_price, this results in NaN.

In this PR, that change is applied to provide more clarity and be more faithful to the results of Uniswap tests.

@dpinones dpinones changed the title Refactor - Add NaN to expected values (Pool 8) Refactor - Add NaN to expected values (Pool 8) Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants