Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop the watcher from reacting to directory events #63

Merged
merged 1 commit into from
Jan 30, 2019

Conversation

cjohansen
Copy link
Contributor

On OSX changing files will often also emit events on the containing directory,
causing excessive test runs while in --watch mode. This manifests as duplicate
test runs, but is especially visible when ignoring certain file patterns.

This commit adds a check for directories and ignores those events.

On OSX changing files will often also emit events on the containing directory,
causing excessive test runs while in --watch mode. This manifests as duplicate
test runs, but is especially visible when ignoring certain file patterns.
@codecov
Copy link

codecov bot commented Jan 30, 2019

Codecov Report

Merging #63 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
+ Coverage   77.47%   77.52%   +0.04%     
==========================================
  Files          40       40              
  Lines        1896     1900       +4     
  Branches      161      161              
==========================================
+ Hits         1469     1473       +4     
  Misses        337      337              
  Partials       90       90
Flag Coverage Δ
#integration 57.63% <20%> (-0.07%) ⬇️
#unit 74.73% <100%> (+0.05%) ⬆️
Impacted Files Coverage Δ
src/kaocha/core_ext.clj 78.78% <100%> (+1.36%) ⬆️
src/kaocha/watch.clj 78.43% <100%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84ee6b4...581064e. Read the comment docs.

@plexus plexus merged commit 88ef9c4 into lambdaisland:master Jan 30, 2019
@plexus
Copy link
Member

plexus commented Jan 30, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants