Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

supports branch name in notebook urls #14

Merged
merged 1 commit into from
Feb 21, 2022
Merged

supports branch name in notebook urls #14

merged 1 commit into from
Feb 21, 2022

Conversation

oxalorg
Copy link
Member

@oxalorg oxalorg commented Feb 15, 2022

make it prettier

@oxalorg
Copy link
Member Author

oxalorg commented Feb 15, 2022 •
edited
Loading

works at https://notebooks.lambdaisland.com/ornament/branch/ox/better-notebook-urls/index.html

Hmmm all direct links work, not the internal <a href> links though
Which is fine I guess?
Maybe even preferable so we always share perma links to internal pages

@oxalorg oxalorg marked this pull request as ready for review February 15, 2022 17:45
@plexus
Copy link
Member

plexus commented Feb 21, 2022

Yeah internal links going to permalinks is I think a plus, we can still manually link to specific notebooks if necessary.

@plexus plexus merged commit 4408180 into main Feb 21, 2022
@plexus
Copy link
Member

plexus commented Feb 21, 2022

Thanks for this!

@plexus plexus deleted the ox/better-notebook-urls branch February 21, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oxalorg @plexus