Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Aggregations #118

Open
16 of 39 tasks
dbulaja98 opened this issue Mar 17, 2023 · 5 comments
Open
16 of 39 tasks

Implement Aggregations #118

dbulaja98 opened this issue Mar 17, 2023 · 5 comments
Labels
good first issue Good for newcomers lambda-hacks-1 1st ZIO Elasticsearch LambdaWorks' Hackathon (June 24th, 2023)
Milestone
0.4.0

Comments

@dbulaja98
Copy link
Collaborator

dbulaja98 commented Mar 17, 2023 •
edited

Aggregations

  • Support adjacencyMatrixAgg
  • Support avgAgg
  • Support bucketSelectorPipelineAgg
  • Support bucketSortPipelineAgg
  • Support cardinalityAgg
  • Support childrenAgg
  • Support dateHistogramAgg
  • Support autoDateHistogramAgg
  • Support dateRangeAgg
  • Support extendedStatsAgg
  • Support filterAgg
  • Support filtersAgg
  • Support geoBoundsAgg
  • Support geoDistanceAgg
  • Support geoHashGridAgg
  • Support geoTileGridAgg
  • Support geoCentroidAgg
  • Support globalAgg
  • Support histogramAgg
  • Support ipRangeAgg
  • Support maxAgg
  • Support minAgg
  • Support missingAgg
  • Support nestedAgg
  • Support percentilesAgg
  • Support percentileRanksAgg
  • Support rangeAgg
  • Support reverseNestedAgg
  • Support samplerAgg
  • Support scriptedMetricAgg
  • Support sigTermsAgg
  • Support statsAgg
  • Support sumAgg
  • Support termsAgg
  • Support topHitsAgg
  • Support topMetricsAgg
  • Support valueCountAgg
  • Support variableWidthHistogramAgg
  • Support weightedAvgAgg

Tips

  • Find comprehensive info about the aggregation you are going to implement here
  • Define aggregation in zio.elasticsearch.aggregation.Aggregations
  • Define the public method that represents aggregation in the zio.elasticsearch.ElasticAggregation object, add scaladoc and website documentation for it
  • Support "withAgg", "withSubAgg" in the zio.elasticsearch.aggregation package, if possible
  • Provide unit tests in the zio.elasticsearch.ElasticAggregationSpec to confirm behavior
  • Provide integration tests (it module) in the zio.elasticsearch.HttpExectorSpec to confirm the behavior
  • 😇 Feel free to extend other tests as well
  • 😊 Feel free to address any follow-up issue either for the aggregation you are implementing or implemented one already

Note: You can use #95 as a reference. If you feel that the pull request size is growing out of control, feel free to split it but make sure to link this issue in each of the related PRs.
@drmarjanovic drmarjanovic added this to the 0.3.0 milestone Apr 10, 2023
@dbulaja98 dbulaja98 added the good first issue Good for newcomers label Apr 20, 2023
@drmarjanovic drmarjanovic mentioned this issue Apr 28, 2023
Merged
@drmarjanovic drmarjanovic mentioned this issue May 9, 2023
Merged
This was referenced May 10, 2023
Merged
Merged
@drmarjanovic drmarjanovic mentioned this issue Jun 8, 2023
Closed
@drmarjanovic drmarjanovic added the lambda-hacks-1 1st ZIO Elasticsearch LambdaWorks' Hackathon (June 24th, 2023) label Jun 23, 2023
@Mitep
Copy link
Contributor

Mitep commented Jun 24, 2023

I'll take avgAgg.

@Mitep
Copy link
Contributor

Mitep commented Jun 24, 2023

I'll take minAgg

@Mitep
Copy link
Contributor

Mitep commented Jun 24, 2023

I'll take sumAgg.

@petarcurcin
Copy link
Contributor

I'll take missingAgg

@Mitep
Copy link
Contributor

Mitep commented Jun 24, 2023

I'll take rangeAgg

This was referenced Jun 24, 2023
Merged
Merged
Merged
Merged
@milicns milicns mentioned this issue Aug 18, 2023
Merged
This was referenced Nov 17, 2023
Merged
Merged
Merged
Merged
Merged
Merged
@dbulaja98 dbulaja98 modified the milestones: 0.3.0, 0.4.0 Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers lambda-hacks-1 1st ZIO Elasticsearch LambdaWorks' Hackathon (June 24th, 2023)
Projects
None yet
Milestone
0.4.0
Development

No branches or pull requests
4 participants
@drmarjanovic @Mitep @petarcurcin @dbulaja98