(dsl): Support Value count aggregation
#352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbulaja98
requested changes
Nov 1, 2023
| val multipleAggregations: MultipleAggregations = valueCountAggregation(name = "valueCountAggregation1", field = Document.stringField).withAgg(valueCountAggregation(name = "valueCountAggregation2", field = Document.stringField)) | ||
| ``` | ||
|
|
||
| You can find more information about `Value count` aggregation [here](https://www.elastic.co/guide/en/elasticsearch/reference/current/search-aggregations-metrics-valuecount-aggregation.html#search-aggregations-metrics-valuecount-aggregation). |
There was a problem hiding this comment.
Add empty line at the end of the file if you didn't.
| * an instance of [[zio.elasticsearch.aggregation.ValueCountAggregation]] that represents value count aggregation to | ||
| * be performed. | ||
| */ | ||
| final def valueCountAggregation(name: String, field: Field[_, String]): ValueCountAggregation = |
There was a problem hiding this comment.
I think that Value count aggregation can be executed on non-textual field. Please check this and fix if necessary.
| @@ -289,7 +289,8 @@ private[elasticsearch] final case class Terms( | |||
| order: Chunk[AggregationOrder], | |||
| subAggregations: Chunk[SingleElasticAggregation], | |||
| size: Option[Int] | |||
| ) extends TermsAggregation { self => | |||
| ) extends TermsAggregation { | |||
| self => | |||
There was a problem hiding this comment.
Put self in the line above.
| sealed trait ValueCountAggregation extends SingleElasticAggregation with WithAgg | ||
|
|
||
| private[elasticsearch] final case class ValueCount(name: String, field: String) extends ValueCountAggregation { | ||
| self => |
There was a problem hiding this comment.
Can you move self to the line above?
dbulaja98
requested changes
Nov 2, 2023
|
|
||
| In order to use the `Value count` aggregation import the following: | ||
| ```scala | ||
| import zio.elasticsearch.aggregation.valueCountAggregation |
There was a problem hiding this comment.
Suggested change
| import zio.elasticsearch.aggregation.valueCountAggregation | |
| import zio.elasticsearch.aggregation.ValueCountAggregation |
|
|
||
| If you want to add aggregation (on the same level), you can use `withAgg` method: | ||
| ```scala | ||
| val multipleAggregations: MultipleAggregations = valueCountAggregation(name = "valueCountAggregation1", field = Document.stringField).withAgg(valueCountAggregation(name = "valueCountAggregation2", field = Document.stringField)) |
There was a problem hiding this comment.
Maybe change field in valueCountAggregation2.
| ) | ||
| .refreshTrue | ||
| ) | ||
| aggregation = valueCountAggregation("aggregation", TestDocument.stringField.keyword) |
dbulaja98
changed the title
dbulaja98
changed the title
Value count aggregation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #118