(dsl): Support Percentile ranks aggregation
#366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanjaftn
changed the title
Percentile ranks aggregation
dbulaja98
requested changes
Nov 19, 2023
| ``` | ||
|
|
||
| You can find more information about `Percentile ranks` aggregation [here](https://www.elastic.co/guide/en/elasticsearch/reference/current/search-aggregations-metrics-percentile-rank-aggregation.html). | ||
|
|
There was a problem hiding this comment.
Is there one or two empty spaces at the end? If two, omit one.
| * parameters. | ||
| * | ||
| * @param field | ||
| * the type-safe field for which stats aggregation will be executed |
There was a problem hiding this comment.
Suggested change
| * the type-safe field for which stats aggregation will be executed | |
| * the type-safe field for which percentile ranks aggregation will be executed |
| final def percentileRanksAggregation[A: Numeric]( | ||
| field: Field[_, A], | ||
| name: String, | ||
| values: Int* |
There was a problem hiding this comment.
Can there be zero values?
There was a problem hiding this comment.
Also, you are missing values in scaladoc.
| * parameters. | ||
| * | ||
| * @param field | ||
| * the field for which stats aggregation will be executed |
There was a problem hiding this comment.
Suggested change
| * the field for which stats aggregation will be executed | |
| * the field for which percentile ranks aggregation will be executed |
| * an instance of [[zio.elasticsearch.aggregation.PercentileRanksAggregation]] that represents percentile ranks | ||
| * aggregation to be performed. | ||
| */ | ||
| final def percentileRanksAggregation(field: String, name: String, values: Int*): PercentileRanksAggregation = |
There was a problem hiding this comment.
Missing values in scaladoc.
modules/library/src/main/scala/zio/elasticsearch/aggregation/Aggregations.scala
Show resolved
Hide resolved
vanjaftn
force-pushed
the
task-support-percentile-rank-aggregation
branch
from
93dbe19
to
23ad012
Compare
vanjaftn
force-pushed
the
task-support-percentile-rank-aggregation
branch
from
aceb9b0
to
3bcdf89
Compare
dbulaja98
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #118