Support meta-modules in auto python env #1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
futujaos
reviewed
Oct 12, 2023
| new_meta_packages = self.requirements_to_meta_packages.get(name, ()) | ||
| for meta_package in new_meta_packages: | ||
| if meta_package.name not in seen_meta_packages: | ||
| meta_packages.add(meta_package) |
There was a problem hiding this comment.
since meta_packages is a set, why we need to support seen_meta_packages instead of just add()?
There was a problem hiding this comment.
Because we could get an early popped meta package later on, it will lead to an infinite loop.
|
|
||
| # it is non-meta package, so classify it as usual | ||
| package = self._classify_distribution(distribution, binary_distributions) | ||
| result.add(package) |
There was a problem hiding this comment.
so method _classify_meta_package_distributions() returns not only meta packages, but also usual packages which cannot be explored since they are meta packages dependency?
There was a problem hiding this comment.
yep
probably I should rename _classify_meta_package_distributions -> _process_meta_packages
imakunin
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.