Add container memory limit #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aapurii
approved these changes
Apr 11, 2024
Comment on lines
22
to
23
| @Nullable | ||
| Long memLimitMb |
There was a problem hiding this comment.
These can be put on one line
There was a problem hiding this comment.
no, no :)
we place annotations on separate lines
Comment on lines
385
to
387
| var killed = client.inspectContainerCmd(containerId) | ||
| .exec() | ||
| .getState().getOOMKilled(); |
imakunin
approved these changes
Apr 11, 2024
imakunin
reviewed
Apr 11, 2024
| return 0; | ||
| } | ||
|
|
||
| if (isOomKilled()) { |
There was a problem hiding this comment.
- you should check OOM before retcode
- right now you do
inspecttwice: on line 254 and line 385
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.