Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add php-cs-fixer to the default set of tools, when configuration for it is detected #127

Merged
merged 3 commits into from
Sep 5, 2022

Conversation

basz
Copy link
Contributor

@basz basz commented Sep 5, 2022

Signed-off-by: Bas Kamer ...@bushbaby.nl

Q A
New Feature yes

Description

This adds direct support for PHP CS Fixer avoiding additional_checks foo in .laminas-ci.json

Signed-off-by: Bas Kamer <bas@bushbaby.nl>
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking ok, but a test addition is needed 👍

Signed-off-by: Bas Kamer <bas@bushbaby.nl>
@basz
Copy link
Contributor Author

basz commented Sep 5, 2022

there you go...

src/tools.ts Outdated Show resolved Hide resolved
Signed-off-by: Bas Kamer <bas@bushbaby.nl>
@Ocramius Ocramius added this to the 1.16.0 milestone Sep 5, 2022
@Ocramius Ocramius self-assigned this Sep 5, 2022
@Ocramius Ocramius changed the title add php-cs-fixer to the default set of tools Add php-cs-fixer to the default set of tools, when configuration for it is detected Sep 5, 2022
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @basz!

@Ocramius Ocramius merged commit 11412b3 into laminas:1.16.x Sep 5, 2022
@Ocramius Ocramius changed the title Add php-cs-fixer to the default set of tools, when configuration for it is detected Add php-cs-fixer to the default set of tools, when configuration for it is detected Sep 5, 2022
@boesing
Copy link
Member

boesing commented Sep 5, 2022

Isnt there also a dist file? Should be added to the files as well imo.

basz added a commit to basz/standard-projections that referenced this pull request Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants