Use output mode configured in ValueGenerator instance
#174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-kl1
force-pushed
the
patch-1
branch
3 times, most recently
from
10ad5d9
to
40df8f5
Compare
Signed-off-by: Thomas Klein <thomasklein876@gmail.com>
|
Hi @Ocramius |
Ocramius
reviewed
Mar 7, 2023
Signed-off-by: Thomas Klein <thomasklein876@gmail.com>
Ocramius
changed the title
ValueGenerator instance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When I want to generate code for an array with the "single line" output, I expect the result to be on a single line. However in the case the array have deeper depth than 1, the result is on multi lines, because the original output mode is not given when generating the child nodes.