Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update markdownlint configuration for list indentation #222

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

froschdesign
Copy link
Member

The configuration for markdownlint has been updated to include setting the indentation of list item to 4 spaces ("MD007"). This is intended to ensure the correct formatting for markdown documents in MkDocs.

References:

The configuration for markdownlint has been updated to include setting the indentation of list item to 4 spaces ("MD007"). This is intended to ensure the correct formatting for markdown documents in MkDocs.

References:

- https://github.com/DavidAnson/markdownlint/blob/main/doc/md007.md
- https://python-markdown.github.io/#differences

Signed-off-by: Frank Brückner <dev@froschdesignstudio.de>
@Xerkus Xerkus added this to the 1.39.0 milestone Mar 8, 2024
@Xerkus Xerkus merged commit ac25544 into laminas:1.39.x Mar 8, 2024
3 checks passed
@froschdesign froschdesign deleted the hotfix/list-indent branch March 8, 2024 11:32
@Ocramius
Copy link
Member

Ocramius commented Mar 11, 2024

Ah, just a note: this obviously broke a hell of pipelines downstream.

@froschdesign is 2 or 4 spaces acceptable, or is 4 strictly necessary for our needs?

@Xerkus
Copy link
Member

Xerkus commented Mar 11, 2024

It is expected.

Strictly 4 due to mkdocs using original markdown, not commonmark, with some strict interpretations of said spec.

See:
mezzio/mezzio#179

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants