-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature for composer 2.0 support #15
Conversation
Interactive mode over slipstreamingStatusaccepted ContextWith DecisionWe change the way how this package interacts with projects. The project lets install any package but gathers, which of these have to be replaced with laminas packages. After composer finishes with dumping the autoloader, this plugin asks the user (in case there were packages installed which had to be replaced) if he wants to replace zendframework packages. The default answer is "yes" (in case, If the answer is "yes", the following flow is executed:
ConsequencesThe user now has to interact with this plugin. We are not auto-replacing zend-packgages anymore. This only happens once for the project OR if you add a non-migrated 3rd-party library, which contains not already replaced zend packages. If the dependency is added to |
370bca4
to
8411d7b
Compare
8411d7b
to
bb89e3c
Compare
Removing unit-testing dev-dependenciesStatusproposed ContextWith
DecisionWe remove the dev-dependencies for unit-testing by default and require them in travis builds. ConsequencesEvery contributor has to manually add the dependencies if he wants to execute unit tests. |
I'd like to get feedback about the proposal to remove dev-dependencies regarding unit testing. As I am busy with the further development of integration tests and some features I'd love if someone else can find a way. Until then, I keep the code as is. |
10c31bc
to
006b335
Compare
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
4bd14ee
to
b616cdd
Compare
Closing in favor of #18 |
Description
With this PR, I am introducing support for composer 2.0 aswell as a new behavior of this plugin (to stay in sync with composer 1.0.
I've added an ADR to the branch to provide some background on the decision to change the behavior of the plugin to a (hopefully) more future-proof way.
You can read this ADR in the next comment aswell as in the PR.
TODO