Add psalm integration #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Creates a psalm.xml.dist for the package. - Adds a `static-analysis` script to `composer.json`. - Updates Travis configuration: - Install `vimeo/psalm` and `psalm/phpunit-plugin` when installing test deps. - Run static-analysis script when TEST_COVERAGE env is present. - Fixes all errors flagged by psalm. - Extracts anonymous class to a test asset, and uses proper type hinting against it in test cases. Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
Codecov Report
@@ Coverage Diff @@
## 2.1.x #26 +/- ##
============================================
- Coverage 92.39% 92.37% -0.03%
Complexity 100 100
============================================
Files 5 5
Lines 342 341 -1
============================================
- Hits 316 315 -1
Misses 26 26
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Prevents conflicts with composer/semver Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
static-analysisscript tocomposer.json.vimeo/psalmandpsalm/phpunit-pluginwhen installing test deps.Fixes #19