Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add psalm integration #26

Merged
merged 3 commits into from
Nov 2, 2020
Merged

Add psalm integration #26

merged 3 commits into from
Nov 2, 2020

Commits on Nov 2, 2020

  1. qa: add psalm integration 

    - Creates a psalm.xml.dist for the package.
- Adds a `static-analysis` script to `composer.json`.
- Updates Travis configuration:
  - Install `vimeo/psalm` and `psalm/phpunit-plugin` when installing test deps.
  - Run static-analysis script when TEST_COVERAGE env is present.
- Fixes all errors flagged by psalm.
  - Extracts anonymous class to a test asset, and uses proper type hinting against it in test cases.

Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
    @weierophinney
    weierophinney committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    a7f5a15 View commit details
    Browse the repository at this point in the history

  2. qa: run static analysis on v2 env only 

    Prevents conflicts with composer/semver

Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
    @weierophinney
    weierophinney committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    fdcff11 View commit details
    Browse the repository at this point in the history

  3. qa: wrap long line flagged by phpcs 

    Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
    @weierophinney
    weierophinney committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    09745d7 View commit details
    Browse the repository at this point in the history