Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PHP 8.1.0 #31

Merged
merged 6 commits into from
Dec 8, 2021
Merged

Conversation

mkoprek
Copy link
Contributor

@mkoprek mkoprek commented Dec 3, 2021

Q A
Documentation no
Bugfix no
BC Break no
New Feature yes
RFC no
QA no

Description

Add support for PHP 8.1.0 for laminas/laminas-diagnostics

Drop support for PHP 7.3

Cause there is no any tag yet in laminas/laminas-code I used a commit hash

Fixes #30

@mkoprek mkoprek force-pushed the add_supoort_php8.1 branch 3 times, most recently from c1c6760 to 7f64c0f Compare December 3, 2021 20:38
@mkoprek mkoprek closed this Dec 3, 2021
@mkoprek mkoprek reopened this Dec 3, 2021
@mkoprek mkoprek force-pushed the add_supoort_php8.1 branch 5 times, most recently from 9cb5eed to 83c7069 Compare December 3, 2021 22:33
Signed-off-by: Maciej Koprek <mkoprek@gmail.com>
.gitignore Outdated Show resolved Hide resolved
src/Check/Memcached.php Outdated Show resolved Hide resolved
Signed-off-by: Maciej Koprek <mkoprek@gmail.com>
composer.json Outdated Show resolved Hide resolved
src/Check/Memcached.php Outdated Show resolved Hide resolved
@Ocramius Ocramius added this to the 1.11.0 milestone Dec 6, 2021
@Ocramius Ocramius removed this from the 1.11.0 milestone Dec 6, 2021
@Ocramius Ocramius changed the base branch from 1.11.x to 1.12.x December 6, 2021 04:26
Signed-off-by: Maciej Koprek <mkoprek@gmail.com>
@mkoprek
Copy link
Contributor Author

mkoprek commented Dec 6, 2021

I removed locking laminas/laminas-code in composer.json
Also I changed if with $memcached->getLastDisconnectedServer().

Now all should be good, but there will be problem with composer install until laminas/laminas-code 4.5.0 will be released.

Signed-off-by: Maciej Koprek <mkoprek@gmail.com>
@mkoprek
Copy link
Contributor Author

mkoprek commented Dec 8, 2021

@Ocramius I changes things you mentioned, could you please review it?

@Ocramius Ocramius added this to the 1.12.0 milestone Dec 8, 2021
@Ocramius Ocramius self-assigned this Dec 8, 2021
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks @mkoprek!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants