-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix builds #30
Fix builds #30
Conversation
src/Headers.php
Outdated
$class = ($this->getPluginClassLoader()->load(str_replace('-', '', $key))) ?: 'Laminas\Http\Header\GenericHeader'; | ||
$class = ( | ||
$this->getPluginClassLoader()->load(str_replace('-', '', $key)) | ||
) ?: 'Laminas\Http\Header\GenericHeader'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brackets around expression are redundant, so I'd suggest the following formatting:
$class = $this->getPluginClassLoader()->load(str_replace('-', '', $key))
?: 'Laminas\Http\Header\GenericHeader';
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are. They increase readability however, in my opinion
All tests failed successfully. Remaining failures are linked to ssl* and tls1.0 disabled by default in test web server.
I believe proper way to fix it would be to remove ssl and use tls only. laminas-http/src/Client/Adapter/Proxy.php Lines 280 to 285 in 2f5982e
Following curl failure needs to be debugged further, potential bug exposure:
|
@Xerkus I am really unsure about failing tests here. All was green there (18h ago last run). I think it might be something wrong with the migration here. |
Difference is test uses |
11307e4
to
45a0c99
Compare
It would have been easier if I bothered to setup test webserver locally in docker. Newer curl complains about chunked transfer that was not properly terminated with zero length chunk. Fixed test asset to emit correct chunked response. |
Description
Fixing tests broken during Laminas migration