Fix compatibility with array_walk() overriden by swoole #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Xerkus
force-pushed
the
hotfix/swoole-callable
branch
from
1468947
to
0a9aa90
Compare
|
@Xerkus any unit tests here? |
|
@michalbundyra No. I don't think they are needed as this is a bug on a swoole side anyway. |
weierophinney
added a commit
that referenced
this pull request
Jul 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Swoole 4.4.0 and higher does not accept array callables in overridden array_walk(). This fix simply converts array callable into closure.