Fails to convert laminas to psr when aminas content is null #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalbundyra
approved these changes
Jan 24, 2020
| $laminasRequest->setContent(null); | ||
|
|
||
| $psr7Request = Psr7ServerRequest::fromLaminas($laminasRequest); | ||
| $this->assertEmpty($psr7Request->getBody()->getContents()); |
There was a problem hiding this comment.
The only thing I could note here is "strict type comparison" - maybe better will be use assertSame('' or assertNull( ?
There was a problem hiding this comment.
Strictness does not matter here. Assertion could have been omitted entirely and counter incremented manually as real assertion here is simply a lack of error.
|
@svycka thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Xerkus said that laminas request can be null and he is right when writing tests I somehow got null end this errored about null written to a stream