Fixed namespace generation in FactoryCreator utility
#133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…amespaces which contains class name Signed-off-by: Ádám Bálint <adam.balint@srg.hu>
Signed-off-by: Ádám Bálint <adam.balint@srg.hu>
adambalint-srg
changed the title
Ocramius
changed the title
FactoryCreator utility
|
Thanks @adambalint-srg! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In FactoryCreator's createFactory method the namespace of the class has been built with
str_replace. This method worked for this kind of classes:Foo\Bar\Service, but the generated namespace was wrong in case of this kind of classes:Foo\Service\Bar\Service, because namespace contains the class name too.With
preg_replaceit is possible to cut off only the last part of the FQCN.