Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow usage with opcache preloading by preventing double-loading of container-interop interfaces #143

Closed
wants to merge 1 commit into from

Conversation

starred-gijs
Copy link

(Replaces #129 as I somehow closed that PR)

Fixes #128

Q A
Bugfix yes
BC Break no
New Feature no
RFC no
QA no

Description

Not sure how to test this, except the manual tests I ran.

@Ocramius Ocramius added Bug Something isn't working Enhancement labels Jun 29, 2022
@Ocramius Ocramius added this to the 3.13.0 milestone Jun 29, 2022
@Ocramius Ocramius changed the title Fix issue with opcache preload see #128 Allow usage with opcache preloading by preventing double-loading container-interop interfaces Jun 29, 2022
@Ocramius Ocramius changed the title Allow usage with opcache preloading by preventing double-loading container-interop interfaces Allow usage with opcache preloading by preventing double-loading of container-interop interfaces Jun 29, 2022
@Ocramius Ocramius added the Duplicate This issue or pull request already exists label Jun 29, 2022
@Ocramius
Copy link
Member

@starred-gijs thanks for the patch, although I merged #141 meanwhile, this will make it to release notes anyway 👍

@Ocramius Ocramius self-assigned this Jun 29, 2022
@starred-gijs starred-gijs deleted the github-128 branch June 29, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Duplicate This issue or pull request already exists Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot declare interface Interop\Container\Exception\NotFoundException, because the name is already in use
2 participants