Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for PHP 8.2, Drop support for PHP 7.4 #156

Merged
merged 4 commits into from
Oct 10, 2022
Merged

Add support for PHP 8.2, Drop support for PHP 7.4 #156

merged 4 commits into from
Oct 10, 2022

Conversation

gsteel
Copy link
Member

@gsteel gsteel commented Oct 10, 2022

Q A
New Feature yes

Description

@gsteel
Drop support for 7.4, Add Support for 8.2, bump dev deps
e647e49 
Signed-off-by: George Steel <george@net-glue.co.uk>
@gsteel
Replace get_class() with $instance::class
00a257d 
Signed-off-by: George Steel <george@net-glue.co.uk>
@gsteel
Expect an instanceof ReflectionNamedType
fa2ec24 
`^8.0` marks `ReflectionType` abstract and moves `isBuiltin` to `ReflectionNamedType`

Signed-off-by: George Steel <george@net-glue.co.uk>
@gsteel gsteel added this to the 3.18.0 milestone Oct 10, 2022
@gsteel
Copy link
Member Author

gsteel commented Oct 10, 2022

@Ocramius - Reinstate ignore_platform_requirements here for ProxyManager?

@Ocramius
Copy link
Member

Would be OK 👍

I don't even know if I have the willpower to work on ProxyManager in the next months, TBH: the "community" killed it for me.

@gsteel
Ignore platform requirements on 8.1 and 8.2 - ProxyManager only suppo…
3e4e0de 
…rts ~8.0

Signed-off-by: George Steel <george@net-glue.co.uk>
@Ocramius Ocramius self-assigned this Oct 10, 2022
Ocramius
Ocramius approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @gsteel!

@Ocramius Ocramius merged commit 5d786a0 into laminas:3.18.x Oct 10, 2022
@gsteel gsteel deleted the PHP-8.2 branch October 10, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
Enhancement
Projects
No open projects
PHP 8.2
Status: Done
Milestone
3.18.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gsteel @Ocramius