Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Psalm support #65

Merged
merged 3 commits into from Jul 24, 2021
Merged

Psalm support #65

merged 3 commits into from Jul 24, 2021

Conversation

fezfez
Copy link
Contributor

@fezfez fezfez commented Dec 15, 2020

fix #54

  • Create a .psalm.xml.dist in the project root
  • Copy and paste the contents from this psalm.xml.dist
  • Run $ composer require vimeo/psalm
  • Run $ vendor/bin/psalm --set-baseline=psalm-baseline.xml
  • Add a composer script static-analysis with the command psalm --shepherd --stats
  • Add a new line to script: in .travis.yml: - if [[ $TEST_COVERAGE == 'true' ]]; then composer static-analysis ; fi
  • Remove phpstan from the project (phpstan.neon.dist, .travis.yml entry, composer.json require-dev and scripts)

composer ^2.0 is now required in dev environnement

@boesing boesing changed the title fix #54 Psalm support Dec 16, 2020
@boesing boesing added this to To do in Psalm via automation Dec 16, 2020
@fezfez
Copy link
Contributor Author

fezfez commented Jan 2, 2021

Hello @weierophinney, can you check this ? Thanks !

@weierophinney
Copy link
Member

@fezfez

Please rebase your patch to add sign-off on each commit; read how in our contributor documentation.

@boesing
Copy link
Member

boesing commented Jan 5, 2021

@weierophinney we might want to have #64 first.
I still think that a new major at this point in time will require a lot of man power to prepare all components to be compatible.

seeing the activity in the last 3 months does not make me think that we should go that road for now.

@fezfez
Copy link
Contributor Author

fezfez commented Jan 17, 2021

@boesing #64 is merged now

@fezfez
Copy link
Contributor Author

fezfez commented Jan 29, 2021

Ping! 🙃

@boesing
Copy link
Member

boesing commented Jan 29, 2021

I'll merge this when we've implemented GHA for CI.
For more details, see laminas/technical-steering-committee#61

There is DCO missing, to fix that, follow the steps which are described here

We will discuss about how we want to proceed with this project in the next TSC meeting (next monday). After this, we can decide how to proceed with this PR aswell.

I think, you should target this PR against 3.7.x for now as we might drop 4.0.x and either re-create it from 3.7.x or we keep 3.x until we have a proper vision for this component.

@weierophinney
Copy link
Member

I've rebased this against current 4.0.x; however, the GHA workflow has not yet made it to the 4.0.x branch, so we need to wait a bit longer.

@fezfez We still need the sign-off in your commit, please; please see my earlier comment for how to do that.

@boesing boesing changed the base branch from 4.0.x to 3.7.x May 16, 2021 20:42
@boesing boesing mentioned this pull request May 16, 2021
fezfez and others added 3 commits July 24, 2021 13:33
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing boesing merged commit 154655f into laminas:3.7.x Jul 24, 2021
Psalm automation moved this from To do to Done Jul 24, 2021
@boesing
Copy link
Member

boesing commented Jul 24, 2021

Thanks, @fezfez

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Psalm
  
Done
Development

Successfully merging this pull request may close these issues.

Psalm integration
3 participants