New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Psalm support #65
Psalm support #65
Conversation
Hello @weierophinney, can you check this ? Thanks ! |
@fezfez — Please rebase your patch to add sign-off on each commit; read how in our contributor documentation. |
@weierophinney we might want to have #64 first. seeing the activity in the last 3 months does not make me think that we should go that road for now. |
Ping! 🙃 |
I'll merge this when we've implemented GHA for CI. There is DCO missing, to fix that, follow the steps which are described here We will discuss about how we want to proceed with this project in the next TSC meeting (next monday). After this, we can decide how to proceed with this PR aswell. I think, you should target this PR against 3.7.x for now as we might drop 4.0.x and either re-create it from 3.7.x or we keep 3.x until we have a proper vision for this component. |
I've rebased this against current 4.0.x; however, the GHA workflow has not yet made it to the 4.0.x branch, so we need to wait a bit longer. @fezfez We still need the sign-off in your commit, please; please see my earlier comment for how to do that. |
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Thanks, @fezfez |
fix #54
.psalm.xml.dist
in the project root$ composer require vimeo/psalm
$ vendor/bin/psalm --set-baseline=psalm-baseline.xml
static-analysis
with the commandpsalm --shepherd --stats
script:
in.travis.yml
:- if [[ $TEST_COVERAGE == 'true' ]]; then composer static-analysis ; fi
phpstan.neon.dist
,.travis.yml
entry,composer.json
require-dev
andscripts
)composer ^2.0 is now required in dev environnement