Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression fix regarding initializers #71

Merged
merged 2 commits into from
Jan 10, 2021
Merged

Conversation

boesing
Copy link
Member

@boesing boesing commented Jan 10, 2021

Q A
Bugfix yes

Description

While backporting changes from 4.x, a change slipped through our fingers and thus introduced an annoying BC break.

Fixes #70

Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing boesing added BC Break Bug Something isn't working labels Jan 10, 2021
@boesing boesing added this to the 3.6.1 milestone Jan 10, 2021
@boesing boesing linked an issue Jan 10, 2021 that may be closed by this pull request
fixes laminas#70
closes laminas#70

Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Ocramius Ocramius merged commit 5583593 into laminas:3.6.x Jan 10, 2021
@boesing boesing deleted the hotfix/70 branch January 10, 2021 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BC Break Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All but the first configured initializers are ignored
2 participants