Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from Travis-Ci to GitHub Actions #83

Merged
merged 4 commits into from
Feb 15, 2021
Merged

Switch from Travis-Ci to GitHub Actions #83

merged 4 commits into from
Feb 15, 2021

Conversation

boesing
Copy link
Member

@boesing boesing commented Feb 15, 2021

Q A
QA yes

Description

As of the decision in one of the laminas TSC meetings, we are switching over to GHA.

@boesing
qa: replace .travis.yml with GHA workflow
8174e60 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing
qa: add benchmark script so CI matrix can work with it
a4b369e 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing boesing added this to In progress in Switch from Travis-Ci to GitHub Actions via automation Feb 15, 2021
@boesing
qa: re-add composer.lock for CI pipeline
976db1f 
Using locked dependencies for codestyle and static analysis is better to avoid failing checks in unrelated PRs

Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@Ocramius
Copy link
Member

On lowest dependencies:


1) LaminasTest\ServiceManager\LazyServiceIntegrationTest::testCanUseLazyServiceFactoryFactoryToCreateLazyServiceFactoryToActAsDelegatorToCreateLazyService
Error: Class "Zend\Code\Generator\ClassGenerator" not found

/github/workspace/vendor/ocramius/proxy-manager/src/ProxyManager/Generator/ClassGenerator.php:15
/github/workspace/vendor/ocramius/proxy-manager/src/ProxyManager/Factory/AbstractBaseFactory.php:104
/github/workspace/vendor/ocramius/proxy-manager/src/ProxyManager/Factory/AbstractBaseFactory.php:72
/github/workspace/vendor/ocramius/proxy-manager/src/ProxyManager/Factory/LazyLoadingValueHolderFactory.php:29
/github/workspace/src/Proxy/LazyServiceFactory.php:65
/github/workspace/src/ServiceManager.php:639
/github/workspace/src/ServiceManager.php:643
/github/workspace/src/ServiceManager.php:667
/github/workspace/src/ServiceManager.php:253
/github/workspace/test/LazyServiceIntegrationTest.php:137

@boesing
Copy link
Member Author

boesing commented Feb 15, 2021 •
edited
Loading

@Ocramius yup, thats due to the fact of this bug in laminas-dependency-plugin:
laminas/laminas-dependency-plugin#28

@boesing boesing mentioned this pull request Feb 15, 2021
Merged
@boesing
qa: require latest version of laminas/laminas-dependency-plugin
f9b1924 
Fixes composer issues regarding PHP 8

Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing
Copy link
Member Author

boesing commented Feb 15, 2021

Okay, I've fixed laminas/laminas-dependency-plugin#28 in laminas/laminas-dependency-plugin v2.1.2 and added it as minimum requirement to this package.

@boesing boesing merged commit 00afa7f into laminas:3.6.x Feb 15, 2021
Switch from Travis-Ci to GitHub Actions automation moved this from In progress to Done Feb 15, 2021
@boesing boesing deleted the qa/continous-integration branch February 15, 2021 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

@snapshotpl snapshotpl snapshotpl approved these changes

Assignees
No one assigned
Labels
Enhancement
Projects
No open projects
Switch from Travis-Ci to GitHub Actions
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@boesing @Ocramius @snapshotpl