Added PHP 8.2 support, dropped PHP 7 support #12
Conversation
glo71317
commented
Dec 5, 2022
•
glo71317
commented
| Q | A |
|---|---|
| Documentation | no |
| Bugfix | no |
| BC Break | no |
| New Feature | yes |
| RFC | no |
| QA | no |
|
Hmm, CI failures highlights some needs for changes. |
|
The test failures need to be addressed, not worked around 😁 |
|
I think the minimum PHPUnit version needs to be raised to 9.5 here |
@Ocramius Thank you so much , this solution has worked here. Still One test case is failing, looking into that |
|
@Ocramius there is one testcase failing due to squizlabs/php_codesniffer. It could be due to same reason as you mentioned in PR laminas/laminas-oauth#20. Can you please confirm? |
|
I wonder if we should just skip PHPCS: we don't want to improve CS on these components, as it poses more risk (regressions). Alternatively, upgrading of |
@Ocramius Yes, upgrading |
There is no blocker over here? Simply means it won't be merged until green here.
IMO no: merging broken stuff is just going to lead to more load on the maintainers: we don't leave stuff half-done here, as it's mostly making thing complicated for everyone else. |
phpcs.xml
Outdated
| @@ -17,24 +17,4 @@ | |||
| <file>test</file> | |||
| <exclude-pattern>*/_files/*</exclude-pattern> | |||
| <exclude-pattern>*/TestAsset/*</exclude-pattern> | |||
|
|
|||
| <!-- Include all rules from Laminas Coding Standard --> | |||
| <rule ref="LaminasCodingStandard"> | |||
There was a problem hiding this comment.
The LaminasCodingStandard should still be preserved
|
@Ocramius We have upgraded the laminas/laminas-coding-standard and updated the code as per the requirement. |
Ocramius
changed the title
Strict types are too problematic to enable in a minor release: we will therefore disable the CS rule that enforces them to be declared. This change also reverts the previous addition of strict types to sources that can crash due to types mismatching internally.
Ocramius
force-pushed
the
php8.2-support
branch
from
101b0cd
to
87bf521
Compare
…debase This codebase is tested, but is old and full of quirks: including static analysis tooling will prevent minor changes from accidentally breaking it over minor details.
…part of PHPUnit < 9
Invalid types were provied/documented in laminas#12, so this is a rewrite of those adjustments.
Also, this provides template parameters for better downstream type inference.
… PHP and PHPCS upgrades
Ocramius
force-pushed
the
php8.2-support
branch
from
35a4f38
to
cca9f0e
Compare
There was a problem hiding this comment.
I had to rewrite the patch to fix multiple changes done incorrectly, such as removed @throws descriptions, incorrect/wrong @var annotations and removed @deprecated comments.
I also squashed previous commits, which were just saying mentioning that some issues were being fixed, without any mention if which they were.
In practice, I understand that you were assigned this task (outsourced?), and that you had no experience with this, but I really wish you had put some thinking into the errors that the CS tooling reported, rather than just steamrolling over the pre-existing code.
Instead, it seems like you've bashed your keyboard until you reached green, which is a bit sad, since it just means double work for maintainers :-(
Anyway, this is now ready for release.
