Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #7 - placeholder view helper return value should be given also with null input #153

Merged

Conversation

gsteel
Copy link
Member

@gsteel gsteel commented Mar 23, 2022

Rebase/Re-Create #49

Fixes #7
Fixes #32
Closes #49

samsonasik and others added 2 commits March 23, 2022 20:17
Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
Signed-off-by: George Steel <george@net-glue.co.uk>
* @return AbstractContainer|self
* @psalm-template T of string|null
* @psalm-param T $name
* @psalm-return (T is null ? self : AbstractContainer)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! :)

Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Ocramius Ocramius added this to the 3.0.0 milestone Mar 24, 2022
@Ocramius Ocramius self-assigned this Mar 24, 2022
@Ocramius Ocramius changed the title Fix 7 placeholder view helper return value Fix #7 - placeholder view helper return value should be given also with null input Mar 24, 2022
@Ocramius Ocramius merged commit 3b5a161 into laminas:3.0.x Mar 24, 2022
@gsteel gsteel deleted the fix-7-placeholder-view-helper-return-value branch March 24, 2022 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Placeholder View Helper "containerExists" makes no sense Fix Placeholder view helper return value
3 participants