Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Placeholder view helper return value #7

Closed
weierophinney opened this issue Dec 31, 2019 · 2 comments · Fixed by #153
Closed

Fix Placeholder view helper return value #7

weierophinney opened this issue Dec 31, 2019 · 2 comments · Fixed by #153
Labels
BC Break
Milestone
3.0.0

Comments

@weierophinney
Copy link
Member

This PR aims to fix the bug, outlined in the following issue: zendframework/zend-view#16

The changes will allow $this as a return value of the view helper, when no name is passed as an argument, thus providing access to the methods inside the view helper. For this reason, more tests have been added to ZendTest\View\Helper\PlaceholderTest.

Originally posted by @thexpand at zendframework/zend-view#162
@weierophinney
Copy link
Member Author

What could we do about the failing Travis build?
If we use zend-mvc ^2.7 it's failing on PHP 7.2 with DEPS=lowest.
If we use zend-mvc ^2.7.13 it's failing on lower PHP versions, because of the minimum stability.

Should I revert the changes, made to the composer.json?

EDIT:
I have reverted my changes. Now the composer.json is the same it was in the beginning. I saw that other PRs are also having this issue.

Originally posted by @thexpand at zendframework/zend-view#162 (comment)

@weierophinney weierophinney mentioned this issue Dec 31, 2019
Open
samsonasik added a commit to samsonasik/laminas-view that referenced this issue Jul 17, 2020
@samsonasik
Fixes laminas#7 Fix Placeholder view helper return value
ee190af
samsonasik added a commit to samsonasik/laminas-view that referenced this issue Jul 17, 2020
@samsonasik
Fixes laminas#7 Fix Placeholder view helper return value
537c3ad 
Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
@samsonasik samsonasik mentioned this issue Jul 17, 2020
Closed
@samsonasik
Copy link
Member

I've created PR #49 for it.

@michalbundyra michalbundyra linked a pull request Jul 17, 2020 that will close this issue
Fixes #7 Fix Placeholder view helper return value #49
Closed
gsteel pushed a commit to gsteel/laminas-view that referenced this issue Mar 23, 2022
@samsonasik @gsteel
Fixes laminas#7 Fix Placeholder view helper return value
4ad9ca5 
Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
@gsteel gsteel mentioned this issue Mar 23, 2022
Merged
@Ocramius Ocramius added this to the 3.0.0 milestone Mar 24, 2022
Ocramius added a commit that referenced this issue Mar 24, 2022
@Ocramius
Merge pull request #153 from gsteel/fix-7-placeholder-view-helper-ret…
3b5a161 
…urn-value

Fix #7 - placeholder view helper return value should be given also with `null` input
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BC Break
Projects
None yet
Milestone
3.0.0
3 participants
@weierophinney @Ocramius @samsonasik