-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properties of entities not properly displayed in docs #52
Comments
You're fast, @Zethson! Immediately spotted my hack :) |
While I am fast from time to time I was made aware by @sunnyosun on this one :) |
Ohhhh, yes, we talked about if you could help us get the code here into canonical form. We're quite happy about the API UX, now (please tell us if you think differently!!! ideally we can settle the basic design), the implementation is a bit all over the place. |
To your suggestions: I'd love it if this could be handled on the implementation level, and not on the documentation level, similar to how it works for I'm not sure, however, whether we can subclass here. My immediate reaction is that we likely need to stick with the decorator (maybe calling it We don't need intersphinx for lnschema-bionty as we're building the docs for all packages in Accessing the docstring directly is also a bit of a hack to me, but evidently better than the current hack. All this said: I think thoroughly looking at this piece of code and thinking through it is probably the best starting point. |
https://lamin.ai/docs/lnschema-bionty/lnschema_bionty.celltype
should look like
Code: https://github.com/laminlabs/lnschema-bionty/blob/main/lnschema_bionty/dev/_bionty.py
A few ideas:
The text was updated successfully, but these errors were encountered: