Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix feature set updates & describe() if no features are present #1098

Merged
merged 10 commits into from Aug 25, 2023

Conversation

falexwolf
Copy link
Member

No description provided.

@falexwolf falexwolf changed the title Describe 🐛 Fix describe() if no features and feature set updates Aug 25, 2023
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #1098 (786c8da) into main (5e098a2) will increase coverage by 0.00%.
Report is 2 commits behind head on main.
The diff coverage is 98.00%.

@@           Coverage Diff           @@
##             main    #1098   +/-   ##
=======================================
  Coverage   92.65%   92.65%           
=======================================
  Files          41       41           
  Lines        3459     3473   +14     
=======================================
+ Hits         3205     3218   +13     
- Misses        254      255    +1     
Files Changed Coverage Δ
lamindb/_parents.py 99.41% <95.83%> (-0.59%) ⬇️
lamindb/dev/_data.py 96.25% <100.00%> (+0.06%) ⬆️
lamindb/dev/_feature_manager.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Aug 25, 2023

@github-actions github-actions bot temporarily deployed to pull request August 25, 2023 17:51 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 25, 2023 18:09 Inactive
@falexwolf falexwolf changed the title 🐛 Fix describe() if no features and feature set updates 🐛 Fix feature set updates & describe() if no features are present Aug 25, 2023
@github-actions github-actions bot temporarily deployed to pull request August 25, 2023 18:25 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 25, 2023 18:50 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 25, 2023 19:15 Inactive
@falexwolf falexwolf merged commit f5ba4e7 into main Aug 25, 2023
12 checks passed
@falexwolf falexwolf deleted the describe branch August 25, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant