Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧 Annotate features during ingestion #110

Merged
merged 11 commits into from Jul 31, 2022
Merged

🚧 Annotate features during ingestion #110

merged 11 commits into from Jul 31, 2022

Conversation

sunnyosun
Copy link
Member

@sunnyosun sunnyosun commented Jul 30, 2022

As discussed: https://www.notion.so/laminlabs/Sunny-Alex-Annotation-design-2022-07-30-48b6f94ad93f4e38bb655f00f7772277

  • Allow ingesting data objects in addition to files.
  • Allow feature_model during ingestion to automatically parse features into LaminDB.

@github-actions
Copy link

github-actions bot commented Jul 31, 2022

@github-actions github-actions bot temporarily deployed to pull request July 31, 2022 08:59 Inactive
@codecov
Copy link

codecov bot commented Jul 31, 2022

Codecov Report

Merging #110 (0ac9401) into main (7a476c7) will decrease coverage by 3.55%.
The diff coverage is 89.38%.

@@            Coverage Diff             @@
##             main     #110      +/-   ##
==========================================
- Coverage   90.82%   87.27%   -3.56%     
==========================================
  Files          28       30       +2     
  Lines         327      385      +58     
==========================================
+ Hits          297      336      +39     
- Misses         30       49      +19     
Impacted Files Coverage Δ
lamindb/dev/file/_file.py 68.42% <44.44%> (-21.58%) ⬇️
lamindb/dev/object/_core.py 71.42% <71.42%> (ø)
lamindb/do/_ingest.py 95.34% <92.85%> (-2.66%) ⬇️
lamindb/dev/db/_insert.py 98.55% <100.00%> (-0.19%) ⬇️
lamindb/dev/file/__init__.py 100.00% <100.00%> (ø)
lamindb/dev/object/__init__.py 100.00% <100.00%> (ø)
lamindb/meta/__init__.py 100.00% <100.00%> (ø)
lamindb/meta/_annotate.py 68.42% <100.00%> (-12.54%) ⬇️
lamindb/meta/_feature_model.py 100.00% <100.00%> (ø)
lamindb/do/_query.py 52.63% <0.00%> (-47.37%) ⬇️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@github-actions github-actions bot temporarily deployed to pull request July 31, 2022 09:24 Inactive
@sunnyosun sunnyosun merged commit c179412 into main Jul 31, 2022
@sunnyosun sunnyosun deleted the ingest_feature branch July 31, 2022 09:26
self._added[filepath] = primary_key

if not filepath.exists():
cache_path = write_to_file(dmem, filekey)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This here wasn't entirely correct usage of the storage API (using key_to_filepath is only valid for data that is already ingested). I'll explain tomorrow if you want!

I made some changes in 114 that fixed it. I'm just saying this so that you aren't astonished! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants