New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚧 Annotate features during ingestion #110
Conversation
Codecov Report
@@ Coverage Diff @@
## main #110 +/- ##
==========================================
- Coverage 90.82% 87.27% -3.56%
==========================================
Files 28 30 +2
Lines 327 385 +58
==========================================
+ Hits 297 336 +39
- Misses 30 49 +19
Help us with your feedback. Take ten seconds to tell us how you rate us. |
self._added[filepath] = primary_key | ||
|
||
if not filepath.exists(): | ||
cache_path = write_to_file(dmem, filekey) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This here wasn't entirely correct usage of the storage API (using key_to_filepath is only valid for data that is already ingested). I'll explain tomorrow if you want!
I made some changes in 114 that fixed it. I'm just saying this so that you aren't astonished! ❤️
As discussed: https://www.notion.so/laminlabs/Sunny-Alex-Annotation-design-2022-07-30-48b6f94ad93f4e38bb655f00f7772277