Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡️ Delete cached files for local instances on File.save() #1109

Merged
merged 2 commits into from Aug 29, 2023

Conversation

Koncopd
Copy link
Member

@Koncopd Koncopd commented Aug 29, 2023

This is to avoid duplication for in-memory data on local instances.

On file = File(data) the in-memory data is saved in the cache folder and then copied to the root on file.save(). data is thus in the cache and in the root. This removes the cached file on file.save() to avoid this duplication.

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #1109 (9a673d1) into main (0e010eb) will increase coverage by 0.03%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1109      +/-   ##
==========================================
+ Coverage   93.50%   93.53%   +0.03%     
==========================================
  Files          41       41              
  Lines        3462     3464       +2     
==========================================
+ Hits         3237     3240       +3     
+ Misses        225      224       -1     
Files Changed Coverage Δ
lamindb/_save.py 80.95% <100.00%> (+1.11%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

@github-actions github-actions bot temporarily deployed to pull request August 29, 2023 17:25 Inactive
@Koncopd Koncopd merged commit dcf2fe0 into main Aug 29, 2023
12 checks passed
@Koncopd Koncopd deleted the clean_cache_local branch August 29, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant