Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Add a members property to FeatureSet #1205

Merged
merged 6 commits into from Sep 27, 2023
Merged

🎨 Add a members property to FeatureSet #1205

merged 6 commits into from Sep 27, 2023

Conversation

falexwolf
Copy link
Member

@falexwolf falexwolf commented Sep 27, 2023

@falexwolf falexwolf changed the title ♻️ Do not double count ♻️ Do not double count dataset provenance mediated through files Sep 27, 2023
@falexwolf falexwolf changed the title ♻️ Do not double count dataset provenance mediated through files 🎨 Add a members property to FeatureSet Sep 27, 2023
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #1205 (051443b) into main (5104707) will decrease coverage by 0.04%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head 051443b differs from pull request most recent head e454029. Consider uploading reports for the commit e454029 to get more accurate results

@@            Coverage Diff             @@
##             main    #1205      +/-   ##
==========================================
- Coverage   95.20%   95.16%   -0.04%     
==========================================
  Files          44       44              
  Lines        3564     3581      +17     
==========================================
+ Hits         3393     3408      +15     
- Misses        171      173       +2     
Files Coverage Δ
lamindb/_dataset.py 98.84% <100.00%> (+0.07%) ⬆️
lamindb/_feature_set.py 100.00% <100.00%> (ø)
lamindb/dev/_data.py 96.31% <100.00%> (-0.91%) ⬇️
lamindb/dev/_feature_manager.py 100.00% <100.00%> (ø)
lamindb/dev/_label_manager.py 88.57% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Sep 27, 2023

@github-actions github-actions bot temporarily deployed to pull request September 27, 2023 18:29 Inactive
@falexwolf falexwolf merged commit 2b0dec1 into main Sep 27, 2023
1 of 9 checks passed
@falexwolf falexwolf deleted the datasetfromfile branch September 27, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant