Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚸 Parse variables upon track, do not access storage during load #1341

Merged
merged 2 commits into from Dec 7, 2023

Conversation

falexwolf
Copy link
Member

@falexwolf falexwolf commented Dec 7, 2023

No description provided.

@falexwolf falexwolf changed the title 🚸 Parse script variables during lamin track and do not access storage… 🚸 Parse variables upon track, do not access storage during load Dec 7, 2023
Copy link

github-actions bot commented Dec 7, 2023

@github-actions github-actions bot temporarily deployed to pull request December 7, 2023 17:02 Inactive
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9486060) 93.60% compared to head (28cf235) 93.59%.
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1341      +/-   ##
==========================================
- Coverage   93.60%   93.59%   -0.01%     
==========================================
  Files          43       43              
  Lines        4143     4153      +10     
==========================================
+ Hits         3878     3887       +9     
- Misses        265      266       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@falexwolf falexwolf merged commit c48a90f into main Dec 7, 2023
8 checks passed
@falexwolf falexwolf deleted the ux branch December 7, 2023 17:46
@github-actions github-actions bot temporarily deployed to pull request December 7, 2023 17:53 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant