Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix idempotency of collection.save() #1401

Merged
merged 4 commits into from Jan 12, 2024
Merged

🐛 Fix idempotency of collection.save() #1401

merged 4 commits into from Jan 12, 2024

Conversation

falexwolf
Copy link
Member

No description provided.

@falexwolf falexwolf changed the title 🐛 Fix idempotency of collection.save() 🐛 Fix idempotency of collection.save() Jan 12, 2024
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (a749051) 92.84% compared to head (364b9cc) 92.58%.
Report is 10 commits behind head on main.

Files Patch % Lines
lamindb/dev/storage/file.py 60.00% 8 Missing ⚠️
lamindb/_run.py 89.47% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1401      +/-   ##
==========================================
- Coverage   92.84%   92.58%   -0.27%     
==========================================
  Files          44       43       -1     
  Lines        4305     4341      +36     
==========================================
+ Hits         3997     4019      +22     
- Misses        308      322      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@github-actions github-actions bot temporarily deployed to pull request January 12, 2024 09:32 Inactive
@falexwolf falexwolf merged commit cf9bba7 into main Jan 12, 2024
11 of 13 checks passed
@falexwolf falexwolf deleted the acidcollection branch January 12, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant