Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add add_to_version_family #1408

Merged
merged 19 commits into from Jan 29, 2024
Merged

✨ Add add_to_version_family #1408

merged 19 commits into from Jan 29, 2024

Conversation

sunnyosun
Copy link
Member

No description provided.

@codecov Codecov
Copy link

codecov bot commented Jan 26, 2024 •
edited

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (1c86963) 92.58% compared to head (62a7097) 92.55%.
Report is 12 commits behind head on main.

❗ Current head 62a7097 differs from pull request most recent head abb2cf2. Consider uploading reports for the commit abb2cf2 to get more accurate results

Files Patch % Lines
lamindb/_registry.py 61.53% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1408      +/-   ##
==========================================
- Coverage   92.58%   92.55%   -0.03%     
==========================================
  Files          43       44       +1     
  Lines        4341     4378      +37     
==========================================
+ Hits         4019     4052      +33     
- Misses        322      326       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 26, 2024 •
edited

🚀 Deployed on https://65b74e74de5e5ff9d22a74f1--lamindb-qnwk.netlify.app

@github-actions github-actions bot temporarily deployed to pull request January 26, 2024 13:28 Inactive
@github-actions github-actions bot temporarily deployed to pull request January 26, 2024 13:51 Inactive
@github-actions github-actions bot temporarily deployed to pull request January 26, 2024 14:54 Inactive
@sunnyosun sunnyosun changed the title 🎨 Update get_uid_from_old_version to auto recognize u_full_id ✨ Add add_to_version_family Jan 26, 2024
@github-actions github-actions bot temporarily deployed to pull request January 26, 2024 15:50 Inactive
@falexwolf falexwolf self-requested a review January 27, 2024 08:59
falexwolf
falexwolf approved these changes Jan 27, 2024
View reviewed changes
Copy link
Member

@falexwolf falexwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! And should pass now!

@github-actions github-actions bot temporarily deployed to pull request January 27, 2024 09:07 Inactive
@github-actions github-actions bot temporarily deployed to pull request January 27, 2024 13:51 Inactive
@sunnyosun sunnyosun merged commit e4fb992 into main Jan 29, 2024
8 checks passed
@sunnyosun sunnyosun deleted the update_uid branch January 29, 2024 06:57
@github-actions github-actions bot temporarily deployed to pull request January 29, 2024 07:06 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@falexwolf falexwolf falexwolf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sunnyosun @falexwolf