Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡️ A way to improve parallel sampling for Collection.mapped #1448

Merged
merged 3 commits into from Feb 23, 2024

Conversation

Koncopd
Copy link
Member

@Koncopd Koncopd commented Feb 22, 2024

Improves from 1.3k samples per second to 1.9k samples per second with 7 workers.

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (6b6b941) 92.55% compared to head (ede0da7) 92.43%.
Report is 24 commits behind head on main.

Files Patch % Lines
lamindb/dev/_mapped_collection.py 33.33% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1448      +/-   ##
==========================================
- Coverage   92.55%   92.43%   -0.13%     
==========================================
  Files          44       44              
  Lines        4395     4428      +33     
==========================================
+ Hits         4068     4093      +25     
- Misses        327      335       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@github-actions github-actions bot temporarily deployed to pull request February 22, 2024 16:24 Inactive
@Koncopd Koncopd merged commit a74c45b into main Feb 23, 2024
11 of 13 checks passed
@Koncopd Koncopd deleted the mapped_parallel branch February 23, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant