Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Disable multiple select results for .add and .delete by fields #502

Merged
merged 3 commits into from Feb 20, 2023

Conversation

sunnyosun
Copy link
Member

@sunnyosun sunnyosun commented Feb 20, 2023

MultipleResultsFound error will be raised with:

  • ln.add(Entity, **kwargs)
  • ln.delete(Entity, **kwargs)

Log whether .add returns an existing entry

@sunnyosun sunnyosun linked an issue Feb 20, 2023 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Feb 20, 2023

@github-actions github-actions bot temporarily deployed to pull request February 20, 2023 11:55 Inactive
@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Merging #502 (570b4d0) into main (c4ef0b9) will decrease coverage by 0.48%.
The diff coverage is 42.85%.

❗ Current head 570b4d0 differs from pull request most recent head 827b4c1. Consider uploading reports for the commit 827b4c1 to get more accurate results

@@            Coverage Diff             @@
##             main     #502      +/-   ##
==========================================
- Coverage   86.31%   85.84%   -0.48%     
==========================================
  Files          39       39              
  Lines        1323     1321       -2     
==========================================
- Hits         1142     1134       -8     
- Misses        181      187       +6     
Impacted Files Coverage Δ
lamindb/_delete.py 67.60% <0.00%> (-5.64%) ⬇️
lamindb/dev/db/_add.py 93.85% <100.00%> (+0.75%) ⬆️
lamindb/_record.py 89.69% <0.00%> (-1.22%) ⬇️
lamindb/dev/db/_select.py 92.00% <0.00%> (-0.80%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sunnyosun sunnyosun linked an issue Feb 20, 2023 that may be closed by this pull request
@sunnyosun sunnyosun merged commit 56f200c into main Feb 20, 2023
@sunnyosun sunnyosun deleted the 388-implementation-of-add-by-fields branch February 20, 2023 12:00
@github-actions github-actions bot temporarily deployed to pull request February 20, 2023 12:08 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implementation of .add by fields Log whether insert returns an existing entry
1 participant