Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Refactor file storage #54

Merged
merged 2 commits into from Jul 3, 2022
Merged

♻️ Refactor file storage #54

merged 2 commits into from Jul 3, 2022

Conversation

falexwolf
Copy link
Member

@falexwolf falexwolf commented Jul 3, 2022

See title.

@github-actions
Copy link

github-actions bot commented Jul 3, 2022

@github-actions github-actions bot temporarily deployed to pull request July 3, 2022 13:07 Inactive
@codecov
Copy link

codecov bot commented Jul 3, 2022

Codecov Report

Merging #54 (de8c8ea) into main (44ca1d1) will decrease coverage by 0.84%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
- Coverage   94.96%   94.11%   -0.85%     
==========================================
  Files          32       33       +1     
  Lines         397      408      +11     
==========================================
+ Hits          377      384       +7     
- Misses         20       24       +4     
Impacted Files Coverage Δ
lamindb/dev/file/_images.py 40.00% <40.00%> (ø)
lamindb/dev/file/_file.py 95.45% <87.50%> (-4.55%) ⬇️
lamindb/dev/file/__init__.py 100.00% <100.00%> (ø)
lamindb/dev/object/_anndata.py 100.00% <100.00%> (ø)
lamindb/do/_ingest.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44ca1d1...de8c8ea. Read the comment docs.

@github-actions github-actions bot temporarily deployed to pull request July 3, 2022 13:17 Inactive
@falexwolf falexwolf merged commit 98c73ab into main Jul 3, 2022
@falexwolf falexwolf deleted the s3 branch July 3, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant