Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Inherit fsspec kwargs from root and move in root check #655

Merged
merged 3 commits into from Apr 23, 2023
Merged

Conversation

Koncopd
Copy link
Member

@Koncopd Koncopd commented Apr 23, 2023

subj

@github-actions
Copy link

github-actions bot commented Apr 23, 2023

@github-actions github-actions bot temporarily deployed to pull request April 23, 2023 15:18 Inactive
@codecov
Copy link

codecov bot commented Apr 23, 2023

Codecov Report

Merging #655 (13718db) into main (f8da7e8) will decrease coverage by 0.17%.
The diff coverage is 59.09%.

@@            Coverage Diff             @@
##             main     #655      +/-   ##
==========================================
- Coverage   78.28%   78.12%   -0.17%     
==========================================
  Files          34       34              
  Lines        1179     1193      +14     
==========================================
+ Hits          923      932       +9     
- Misses        256      261       +5     
Impacted Files Coverage Δ
lamindb/_file.py 82.39% <59.09%> (+0.30%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot temporarily deployed to pull request April 23, 2023 16:07 Inactive
@Koncopd Koncopd merged commit 2541fac into main Apr 23, 2023
3 of 5 checks passed
@Koncopd Koncopd deleted the fsspec_args branch April 23, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant