🚚 Move default storage location from lndb/ to .lamindb/
#796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
falexwolf
commented
Jun 22, 2023
•
falexwolf
commented
- https://laminlabs.slack.com/archives/C04FPE8V01W/p1687432570162689
Codecov Report
@@ Coverage Diff @@
## main #796 +/- ##
==========================================
- Coverage 77.92% 77.90% -0.02%
==========================================
Files 31 31
Lines 1712 1715 +3
==========================================
+ Hits 1334 1336 +2
- Misses 378 379 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
falexwolf
changed the title
lndb/ to .lamindb/
Koncopd
reviewed
Jun 22, 2023
lamindb/_file_methods.py
Outdated
| @@ -198,11 +198,15 @@ def inner(dir_path: Union[Path, UPath], prefix: str = "", level=-1): | |||
| nonlocal files, directories | |||
| if not level: | |||
| return # 0, stop iterating | |||
| stripped_dir_path = dir_path.as_posix().rstrip("/") | |||
| # do not iterate through zarr directories | |||
| if stripped_dir_path.endswith(".zarr"): | |||
There was a problem hiding this comment.
Right, thanks for spotting this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.