Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃毟 Return locally backed object instead of cloud backed if available, rename to_adata() to to_memory() #840

Merged
merged 2 commits into from Jul 4, 2023

Conversation

falexwolf
Copy link
Member

@falexwolf falexwolf commented Jul 4, 2023

More consistency across cloud-backed and disk-backed! Hope this is OK, @Koncopd!

@falexwolf falexwolf changed the base branch from main to staging July 4, 2023 11:25
@falexwolf falexwolf changed the title Backed 馃毟 Return locally backed object instead of cloud backed if available, rename to_adata() to to_memory() Jul 4, 2023
@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #840 (8217815) into staging (72bbd8b) will increase coverage by 0.22%.
The diff coverage is 85.60%.

@@             Coverage Diff             @@
##           staging     #840      +/-   ##
===========================================
+ Coverage    84.72%   84.94%   +0.22%     
===========================================
  Files           31       32       +1     
  Lines         1983     2079      +96     
===========================================
+ Hits          1680     1766      +86     
- Misses         303      313      +10     
Impacted Files Coverage 螖
lamindb/_context.py 61.00% <45.00%> (-0.06%) 猬囷笍
lamindb/_delete.py 44.44% <66.66%> (-2.62%) 猬囷笍
lamindb/_file.py 90.52% <77.77%> (-0.49%) 猬囷笍
lamindb/_queryset.py 95.00% <95.00%> (酶)
lamindb/__init__.py 100.00% <100.00%> (酶)
lamindb/_feature_set.py 90.47% <100.00%> (+0.23%) 猬嗭笍
lamindb/_save.py 75.23% <100.00%> (+0.72%) 猬嗭笍
lamindb/_select.py 91.66% <100.00%> (酶)
lamindb/dev/__init__.py 100.00% <100.00%> (酶)
lamindb/dev/hashing.py 100.00% <100.00%> (酶)
... and 1 more

... and 2 files with indirect coverage changes

馃摚 We鈥檙e building smart automated test selection to slash your CI/CD build times. Learn more

@sunnyosun sunnyosun merged commit c29bc8c into staging Jul 4, 2023
10 checks passed
@sunnyosun sunnyosun deleted the backed branch July 4, 2023 11:30
@github-actions
Copy link

github-actions bot commented Jul 4, 2023

@github-actions github-actions bot temporarily deployed to pull request July 4, 2023 11:32 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants