Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Enable to create File outside default storage #891

Merged
merged 5 commits into from Jul 17, 2023
Merged

Conversation

falexwolf
Copy link
Member

@falexwolf falexwolf commented Jul 17, 2023

@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #891 (ab4784d) into staging (15aeff6) will decrease coverage by 0.11%.
The diff coverage is 95.45%.

@@             Coverage Diff             @@
##           staging     #891      +/-   ##
===========================================
- Coverage    86.64%   86.54%   -0.11%     
===========================================
  Files           34       34              
  Lines         2404     2422      +18     
===========================================
+ Hits          2083     2096      +13     
- Misses         321      326       +5     
Impacted Files Coverage Δ
lamindb/_file.py 91.13% <95.23%> (-0.69%) ⬇️
lamindb/dev/storage/file.py 78.18% <100.00%> (+3.63%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Jul 17, 2023

@github-actions github-actions bot temporarily deployed to pull request July 17, 2023 11:22 Inactive
@falexwolf falexwolf changed the title 🚚 Rename get_check_path_in_storage to check_pack_in_default_storage 🚚 Enable creating File outside default storage Jul 17, 2023
@falexwolf falexwolf changed the title 🚚 Enable creating File outside default storage ✨ Enable to create File outside default storage Jul 17, 2023
@github-actions github-actions bot temporarily deployed to pull request July 17, 2023 14:49 Inactive
@falexwolf falexwolf merged commit 899c781 into staging Jul 17, 2023
1 of 6 checks passed
@falexwolf falexwolf deleted the outofdefault branch July 17, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant