Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚸 Only link validated features #987

Merged
merged 7 commits into from Aug 5, 2023
Merged

🚸 Only link validated features #987

merged 7 commits into from Aug 5, 2023

Conversation

falexwolf
Copy link
Member

@falexwolf falexwolf commented Aug 5, 2023

@falexwolf falexwolf changed the title Valid 🚸 Only link validated features Aug 5, 2023
@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Merging #987 (e4bf3cc) into staging (0d83da6) will increase coverage by 0.03%.
Report is 2 commits behind head on staging.
The diff coverage is 96.00%.

❗ Current head e4bf3cc differs from pull request most recent head 37444c5. Consider uploading reports for the commit 37444c5 to get more accurate results

@@             Coverage Diff             @@
##           staging     #987      +/-   ##
===========================================
+ Coverage    86.32%   86.35%   +0.03%     
===========================================
  Files           38       38              
  Lines         3086     3152      +66     
===========================================
+ Hits          2664     2722      +58     
- Misses         422      430       +8     
Files Changed Coverage Δ
lamindb/_feature_manager.py 91.54% <50.00%> (-0.60%) ⬇️
lamindb/_feature_set.py 90.44% <96.87%> (+0.96%) ⬆️
lamindb/_file.py 89.80% <100.00%> (+0.08%) ⬆️
lamindb/_from_values.py 96.13% <100.00%> (+0.60%) ⬆️
lamindb/types.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Aug 5, 2023

@github-actions github-actions bot temporarily deployed to pull request August 5, 2023 15:01 Inactive
@falexwolf falexwolf merged commit f855e0d into staging Aug 5, 2023
3 of 6 checks passed
@falexwolf falexwolf deleted the valid branch August 5, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant